Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: Source/platform/mediastream/MediaStreamSource.cpp

Issue 534473002: Revert of Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/mediastream/MediaStreamSource.h ('k') | public/platform/WebMediaStream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/mediastream/MediaStreamSource.cpp
diff --git a/Source/platform/mediastream/MediaStreamSource.cpp b/Source/platform/mediastream/MediaStreamSource.cpp
index 2a906c5cbef3a66405cfdcfa7717425076ae3877..d8a71289d8291d47c3a74f3d21b62bd9d7be310c 100644
--- a/Source/platform/mediastream/MediaStreamSource.cpp
+++ b/Source/platform/mediastream/MediaStreamSource.cpp
@@ -34,9 +34,9 @@
namespace blink {
-MediaStreamSource* MediaStreamSource::create(const String& id, Type type, const String& name, ReadyState readyState, bool requiresConsumer)
+PassRefPtr<MediaStreamSource> MediaStreamSource::create(const String& id, Type type, const String& name, ReadyState readyState, bool requiresConsumer)
{
- return new MediaStreamSource(id, type, name, readyState, requiresConsumer);
+ return adoptRef(new MediaStreamSource(id, type, name, readyState, requiresConsumer));
}
MediaStreamSource::MediaStreamSource(const String& id, Type type, const String& name, ReadyState readyState, bool requiresConsumer)
@@ -52,15 +52,21 @@
{
if (m_readyState != ReadyStateEnded && m_readyState != readyState) {
m_readyState = readyState;
- for (HeapHashSet<WeakMember<Observer> >::iterator i = m_observers.begin(); i != m_observers.end(); ++i)
+ for (Vector<Observer*>::iterator i = m_observers.begin(); i != m_observers.end(); ++i)
(*i)->sourceChangedState();
}
}
void MediaStreamSource::addObserver(MediaStreamSource::Observer* observer)
{
- ASSERT(!m_observers.contains(observer));
- m_observers.add(observer);
+ m_observers.append(observer);
+}
+
+void MediaStreamSource::removeObserver(MediaStreamSource::Observer* observer)
+{
+ size_t pos = m_observers.find(observer);
+ if (pos != kNotFound)
+ m_observers.remove(pos);
}
void MediaStreamSource::addAudioConsumer(PassRefPtr<AudioDestinationConsumer> consumer)
@@ -98,10 +104,4 @@
(*it)->consumeAudio(bus, numberOfFrames);
}
-void MediaStreamSource::trace(Visitor* visitor)
-{
- visitor->trace(m_observers);
-}
-
} // namespace blink
-
« no previous file with comments | « Source/platform/mediastream/MediaStreamSource.h ('k') | public/platform/WebMediaStream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698