Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 534473002: Revert of Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, philipj_slow, dglazkov+blink, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, Raymond Toy
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor to oilpan's heap (patchset #5 id:80001 of https://codereview.chromium.org/509933002/) Reason for revert: Broke multiple tests in content_unittests. e.g. https://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/39151 Original issue's description: > Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor to oilpan's heap > > - MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor must be moved to oilpan's heap in one go because their lifetime are tightly coupled. > > - Removed m_descriptor->setClient(0) from MediaStream's destructor. This is OK because MediaStreamDescriptor has a strong Member back to the Client (i.e., MediaStream). > > - Removed m_component->source()->removeObserver(this) from MediaStreamTrack's destructor. This is OK because this CL made the observers weak (i.e., MediaStreamSource::m_observers is a hash set of weak members to MediaStreamTrack objects). > > - Removed WebMediaStreamTrack::ExtraData::m_owner because it's unused. > > > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181204 TBR=oilpan-reviews@chromium.org,zerny@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -104 lines) Patch
M Source/modules/mediastream/MediaStream.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/mediastream/MediaStreamRegistry.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebMediaStream.cpp View 2 chunks +11 lines, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamTrack.cpp View 3 chunks +26 lines, -0 lines 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.h View 4 chunks +7 lines, -9 lines 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.cpp View 2 chunks +5 lines, -10 lines 0 comments Download
M Source/platform/mediastream/MediaStreamDescriptor.h View 4 chunks +13 lines, -14 lines 0 comments Download
M Source/platform/mediastream/MediaStreamDescriptor.cpp View 5 chunks +10 lines, -17 lines 0 comments Download
M Source/platform/mediastream/MediaStreamSource.h View 4 chunks +6 lines, -9 lines 0 comments Download
M Source/platform/mediastream/MediaStreamSource.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M public/platform/WebMediaStream.h View 1 chunk +3 lines, -1 line 0 comments Download
M public/platform/WebMediaStreamSource.h View 3 chunks +2 lines, -7 lines 0 comments Download
M public/platform/WebMediaStreamTrack.h View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
Created Revert of Oilpan: Move MediaStreamSource, MediaStreamComponent and MediaStreamDescriptor to oilpan's heap
6 years, 3 months ago (2014-09-02 02:32:48 UTC) #1
haraken
6 years, 3 months ago (2014-09-02 02:37:49 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698