Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: runtime/vm/raw_object.h

Issue 534433002: - Revert parts of r39731 as they cause conflicting results. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h (revision 39731)
+++ runtime/vm/raw_object.h (working copy)
@@ -330,13 +330,7 @@
void ClearMarkBit() {
ASSERT(IsMarked());
uword tags = ptr()->tags_;
- uword old_tags;
- do {
- old_tags = tags;
- uword new_tags = MarkBit::update(false, old_tags);
- tags = AtomicOperations::CompareAndSwapWord(
- &ptr()->tags_, old_tags, new_tags);
- } while (tags != old_tags);
+ ptr()->tags_ = MarkBit::update(false, tags);
}
// Support for GC watched bit.
@@ -389,23 +383,11 @@
void SetRememberedBit() {
ASSERT(!IsRemembered());
uword tags = ptr()->tags_;
- uword old_tags;
- do {
- old_tags = tags;
- uword new_tags = RememberedBit::update(true, old_tags);
- tags = AtomicOperations::CompareAndSwapWord(
- &ptr()->tags_, old_tags, new_tags);
- } while (tags != old_tags);
+ ptr()->tags_ = RememberedBit::update(true, tags);
}
void ClearRememberedBit() {
uword tags = ptr()->tags_;
- uword old_tags;
- do {
- old_tags = tags;
- uword new_tags = RememberedBit::update(false, old_tags);
- tags = AtomicOperations::CompareAndSwapWord(
- &ptr()->tags_, old_tags, new_tags);
- } while (tags != old_tags);
+ ptr()->tags_ = RememberedBit::update(false, tags);
}
bool IsDartInstance() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698