Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 534393002: Remove NavigationRequestInfo::is_showing. (Closed)

Created:
6 years, 3 months ago by davidben
Modified:
6 years, 3 months ago
Reviewers:
clamy, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove NavigationRequestInfo::is_showing. Trying to initialize it causes content_shell --enable-browser-side-navigation to crash on startup. It corresponds to ResourceRequestInfo::GetVisibilityState, but that's only used for categorizing requests made from prerender which needs a different bit (WebPageVisiblityStatePrerender vs. others), so we'll need to revisit it anyway. BUG=376014 Committed: https://crrev.com/90147459e59132fea1c6254e9d30478735ec7247 Cr-Commit-Position: refs/heads/master@{#293211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M content/browser/frame_host/navigation_request_info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
davidben
May as well split this out of the rest of the RDH stuff since it's ...
6 years, 3 months ago (2014-09-03 18:41:38 UTC) #2
nasko
LGTM
6 years, 3 months ago (2014-09-03 18:46:22 UTC) #3
clamy
lgtm
6 years, 3 months ago (2014-09-03 18:49:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/534393002/1
6 years, 3 months ago (2014-09-03 18:53:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 19:57:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 142a78b5c6f45b0892f24f66ee1be60e727bd78c
6 years, 3 months ago (2014-09-03 23:15:59 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90147459e59132fea1c6254e9d30478735ec7247
Cr-Commit-Position: refs/heads/master@{#293211}

Powered by Google App Engine
This is Rietveld 408576698