Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 534363002: Merge performance fix for cmsDupToneCurve from previous upstream branch. (Closed)

Created:
6 years, 3 months ago by palmer
Modified:
6 years, 3 months ago
Reviewers:
Bo Xu, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Merge performance fix for cmsDupToneCurve from previous upstream branch. BUG= R=jun_fang@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/1efeeeb1d9d74dc50e7a62859c1944158e72560e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
palmer
Please take a look. Thanks! Also, what are the other differences between PDFium and other ...
6 years, 3 months ago (2014-09-03 18:11:28 UTC) #2
jun_fang
https://codereview.chromium.org/534363002/diff/1/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c File core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c (right): https://codereview.chromium.org/534363002/diff/1/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c#newcode825 core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c:825: if (In == NULL || In ->InterpParams == NULL ...
6 years, 3 months ago (2014-09-03 18:52:13 UTC) #3
jun_fang
On 2014/09/03 18:52:13, jun_fang wrote: > https://codereview.chromium.org/534363002/diff/1/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c > File core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c (right): > > https://codereview.chromium.org/534363002/diff/1/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsgamma.c#newcode825 > ...
6 years, 3 months ago (2014-09-04 01:50:28 UTC) #4
palmer
6 years, 3 months ago (2014-09-08 23:12:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1efeeeb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698