Issue 534353002: Fix the build error of athena on chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534353002: Fix the build error of athena on chrome. (Closed)

Created:
6 years, 3 months ago by Jun Mukai

Modified:
6 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix the build error of athena on chrome. BUG=None R=oshima@chromium.org TEST=buid chrome with use_athena=1 NOTRY=TRUE Committed: https://crrev.com/a820d4fda0ae7a0bf60cfc7e6474573cdee23b63 Cr-Commit-Position: refs/heads/master@{#293183}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	athena/extensions/chrome/extensions_delegate_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/534353002/1

6 years, 3 months ago (2014-09-03 17:54:15 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 7a31e7b060c27b5300eea90a9633dff22de0a836

6 years, 3 months ago (2014-09-03 19:10:41 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:27:19 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a820d4fda0ae7a0bf60cfc7e6474573cdee23b63
Cr-Commit-Position: refs/heads/master@{#293183}