Adding Paste Popup behavior Unit Test cases.

Adding Paste Popup behavior Unit Test cases.

Currently there is not enough unit test cases available to cover
the functionality of Paste Popup menu behavior. This patch covers
essential unit test cases for the same.

BUG=

Committed: https://crrev.com/29b711e2bf98d6cf1ce99541f3d47bda33acb32f
Cr-Commit-Position: refs/heads/master@{#293222}

[AKVT, 2014-09-03 17:36:24]

ajith.v@samsung.com changed reviewers:
+ aurimas@chromium.org, jdduke@chromium.org

[AKVT, 2014-09-03 17:36:24]

@jdduke & aurima PTAL. Added more unit test cases for Paste Popup menu behavior.

[jdduke (slow), 2014-09-03 18:08:07]

https://codereview.chromium.org/534343002/diff/20001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/534343002/diff/20001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:248:
DOMUtils.focusNode(mContentViewCore, "input_text");
This behavior is only tangentially related to IME (i.e., cut/copy/paste commands
are simply forwarded by ImeAdapter.java, they don't meaningfully interact with
the adapter). 

I think you can test this functionality using minimal interaction with IME
itself, e.g., you can programatically add text to the clipboard: 

 ClipboardManager clipboard = (ClipboardManager)
getSystemService(CLIPBOARD_SERVICE); 
 ClipData clip = ClipData.newPlainText("test", "Text to copy");
 clipboard.setPrimaryClip(clip);

then you can avoid the boilerplate of commit/selectall/cut on these tests.  With
that, I would move all of these tests to ContentViewCoreSelectionTest.java.

[AKVT, 2014-09-03 19:23:17]

@jdduke PTAL

https://codereview.chromium.org/534343002/diff/20001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/534343002/diff/20001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:248:
DOMUtils.focusNode(mContentViewCore, "input_text");
On 2014/09/03 18:08:07, jdduke wrote:
> This behavior is only tangentially related to IME (i.e., cut/copy/paste
commands
> are simply forwarded by ImeAdapter.java, they don't meaningfully interact with
> the adapter). 
> 
> I think you can test this functionality using minimal interaction with IME
> itself, e.g., you can programatically add text to the clipboard: 
> 
>  ClipboardManager clipboard = (ClipboardManager)
> getSystemService(CLIPBOARD_SERVICE); 
>  ClipData clip = ClipData.newPlainText("test", "Text to copy");
>  clipboard.setPrimaryClip(clip);
> 
> then you can avoid the boilerplate of commit/selectall/cut on these tests. 
With
> that, I would move all of these tests to ContentViewCoreSelectionTest.java.

Thanks for the suggestion, I had corrected it and moved to
ContentViewCoreSelectionTest.java.

[AKVT, 2014-09-03 19:26:16]

@jdduke PS4 is best to review.

[jdduke (slow), 2014-09-03 19:30:28]

Thanks, lgtm with one nit.

https://codereview.chromium.org/534343002/diff/60001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
(right):

https://codereview.chromium.org/534343002/diff/60001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:47:
assertWaitForSelectActionBarStatus(false);
Maybe add a |assertWaitForPastePopupStatus(false);| here as a precondition.

[AKVT, 2014-09-03 19:32:50]

Thanks. Done

https://codereview.chromium.org/534343002/diff/60001/content/public/android/j...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
(right):

https://codereview.chromium.org/534343002/diff/60001/content/public/android/j...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:47:
assertWaitForSelectActionBarStatus(false);
On 2014/09/03 19:30:28, jdduke wrote:
> Maybe add a |assertWaitForPastePopupStatus(false);| here as a precondition.

Done. Thanks

[AKVT, 2014-09-03 19:53:51]

The CQ bit was checked by ajith.v@samsung.com

[commit-bot: I haz the power, 2014-09-03 19:55:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajith.v@samsung.com/534343002/80001

[commit-bot: I haz the power, 2014-09-03 23:42:45]

Committed patchset #5 (id:80001) as 09a5dabaa2016563444e14738bd507d9857023fa

[commit-bot: I haz the power, 2014-09-10 03:28:35]

Patchset 5 (id:??) landed as
https://crrev.com/29b711e2bf98d6cf1ce99541f3d47bda33acb32f
Cr-Commit-Position: refs/heads/master@{#293222}