Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 534293003: DevTools: Switch shared workers inspection on to the main thread. (Closed)

Created:
6 years, 3 months ago by vsevik
Modified:
6 years, 3 months ago
Reviewers:
sergeyv, pfeldman, yurys, horo
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

DevTools: Switch shared workers inspection on to the main thread. BUG=404355 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181674

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -77 lines) Patch
M Source/web/WebSharedWorkerImpl.h View 6 chunks +10 lines, -6 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 10 chunks +51 lines, -67 lines 1 comment Download
M public/web/WebSharedWorker.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vsevik
6 years, 3 months ago (2014-09-04 05:23:45 UTC) #1
vsevik
6 years, 3 months ago (2014-09-04 05:24:03 UTC) #3
vsevik
PTAL
6 years, 3 months ago (2014-09-04 05:24:10 UTC) #4
horo
lgtm with nit. https://codereview.chromium.org/534293003/diff/1/Source/web/WebSharedWorkerImpl.cpp File Source/web/WebSharedWorkerImpl.cpp (right): https://codereview.chromium.org/534293003/diff/1/Source/web/WebSharedWorkerImpl.cpp#newcode396 Source/web/WebSharedWorkerImpl.cpp:396: if (InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart(document)) nit: It is better ...
6 years, 3 months ago (2014-09-04 05:44:03 UTC) #5
pfeldman
lgtm
6 years, 3 months ago (2014-09-09 16:43:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/534293003/1
6 years, 3 months ago (2014-09-09 18:52:43 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 20:45:08 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181674

Powered by Google App Engine
This is Rietveld 408576698