Issue 534263002: Fix python bindings generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534263002: Fix python bindings generator. (Closed)

Created:
6 years, 3 months ago by qsr

Modified:
6 years, 3 months ago

Reviewers:
dzhioev (left Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix python bindings generator. The declared output was incorrect, forcing a systematic rebuild. R=dzhioev@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2ae76bbd6e9530d79ee5bc9e27ca449de4f057ef

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/public/tools/bindings/mojom_bindings_generator.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/534263002/1

6 years, 3 months ago (2014-09-03 14:05:33 UTC) #5

qsr

Committed patchset #1 (id:1) manually as 2ae76bb (presubmit successful).

6 years, 3 months ago (2014-09-03 15:02:15 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:25:42 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2ae76bbd6e9530d79ee5bc9e27ca449de4f057ef
Cr-Commit-Position: refs/heads/master@{#293135}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages