Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 534233002: Make sure to use the correct referrer policy in the FrameFetchContext (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Mike West
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Project:
blink
Visibility:
Public.

Description

Make sure to use the correct referrer policy in the FrameFetchContext Before, we might have used the referrer from the request, but the policy from the document. Since when then didn't update the request, an invalid referrer might have slipped. BUG=407510 R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181317

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
A LayoutTests/http/tests/security/referrer-policy-conflicting-policies.html View 1 chunk +6 lines, -0 lines 1 comment Download
A LayoutTests/http/tests/security/referrer-policy-conflicting-policies-expected.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/resources/green-if-no-referrer.php View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/resources/referrer-policy-conflicting-policies.html View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-03 13:03:49 UTC) #1
Mike West
LGTM with a nit that we can take care of in a future CL when ...
6 years, 3 months ago (2014-09-03 13:11:08 UTC) #2
jochen (gone - plz use gerrit)
i want to be able to merge this back without too much drama, so a ...
6 years, 3 months ago (2014-09-03 13:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/534233002/1
6 years, 3 months ago (2014-09-03 13:13:54 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 14:07:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181317

Powered by Google App Engine
This is Rietveld 408576698