Issue 53423003: WIP: Update AXObjects when a modal dialog is opened/closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53423003: WIP: Update AXObjects when a modal dialog is opened/closed (Closed)

Created:
7 years, 1 month ago by falken

Modified:
7 years, 1 month ago

Reviewers:
dmazzoni

CC:
blink-reviews, dglazkov+blink, dmazzoni, adamk+blink_chromium.org, aboxhall

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

WIP: Update AXObjects when a modal dialog is opened/closed BUG=

Patch Set 1 #

Patch Set 2 : update tree #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -8 lines)			Patch
M	Source/core/accessibility/AXObject.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXObject.cpp	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	Source/core/accessibility/AXObjectCache.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/accessibility/AXObjectCache.cpp	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLDialogElement.cpp	View	1	4 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

falken

Dominic, this is a WIP patch if you have comments. The patch improves the situation, ...

7 years, 1 month ago (2013-10-31 12:38:25 UTC) #1

dmazzoni

7 years, 1 month ago (2013-10-31 16:01:22 UTC) #2

Hmmm.

One thing to watch out for: if m_computedObjectAttributeCache->clear() is not
called, then "accessibilityIsIgnored" values are cached. It's triggered whenever
a notification is posted, but maybe one isn't happening early enough - maybe
trigger it as soon as a dialog opens/closes?

If that doesn't solve it, maybe we should start with the simplest solution that
actually works, and worry about optimizing it later. Even just iterating over
every AX object doesn't sound that bad - it should only take a few ms to walk
the whole tree once, and we'd only pay the cost when the dialog opens or closes.

Expand Messages | Collapse Messages