Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 534163002: Move app.window API implementation to extensions (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jackhou1, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move app.window API implementation to extensions Move files: -Move chrome/browser/extensions/api/app_window/* to extensions/browser. -Move app_window.idl, app_window_custom_bindings.{cc,h}, app_window_custom_bindings.js to extensions. -Move window_controls.js and window_controls_template.html to extensions. Move switches and code: - Move kEnableAppWindowControls switch to extensions/common/switches.h. - Move dummy WebContentsModalDialogManager::CreateNativeWebModalManager implementation from athena's web_contents_view_delegate_factory_impl.cc to a new file shell_web_contents_modal_dialog_manager.cc. Fix dispatchers: - Move code from chrome_extensions_dispatcher_delegate.cc to extensions/renderer/dispatcher.cc BUG=387288 Committed: https://crrev.com/f784afd4de115dba788b0adc7034a15846765ff5 Cr-Commit-Position: refs/heads/master@{#293409}

Patch Set 1 : #

Patch Set 2 : Fix GN #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : Fix OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1929 lines) Patch
M apps/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M athena/content/web_contents_view_delegate_factory_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/window_controls_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/app_window/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/app_window/app_window_api.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/extensions/api/app_window/app_window_api.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D chrome/browser/extensions/api/app_window/app_window_apitest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/extensions/api/app_window.idl View 1 chunk +0 lines, -460 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/extensions/app_window_custom_bindings.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/renderer/extensions/app_window_custom_bindings.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 5 chunks +1 line, -8 lines 0 comments Download
D chrome/renderer/resources/extensions/app_window_custom_bindings.js View 1 chunk +0 lines, -401 lines 0 comments Download
D chrome/renderer/resources/extensions/window_controls.js View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/renderer/resources/extensions/window_controls_template.html View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/app_window/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/app_window/app_window_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/app_window/app_window_api.cc View 8 chunks +15 lines, -16 lines 0 comments Download
A + extensions/browser/api/app_window/app_window_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/common/api/app_window.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 chunk +4 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
A + extensions/renderer/app_window_custom_bindings.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/app_window_custom_bindings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 4 chunks +8 lines, -0 lines 0 comments Download
A + extensions/renderer/resources/app_window_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A + extensions/renderer/resources/window_controls.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/window_controls_template.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
hashimoto
6 years, 3 months ago (2014-09-03 11:42:12 UTC) #3
benwells
lgtm. +cc jackhou as fyi that should soon be an owner for app window api. ...
6 years, 3 months ago (2014-09-04 06:55:29 UTC) #4
hashimoto
jochen@: Could you review chrome/renderer/resources/renderer_resources.grd as an owner? oshima@: Could you review athena/content/web_contents_view_delegate_factory_impl.cc as an ...
6 years, 3 months ago (2014-09-04 09:20:08 UTC) #6
jochen (gone - plz use gerrit)
c/r/resources/renderer_resources.grd lgtm
6 years, 3 months ago (2014-09-04 10:02:26 UTC) #7
oshima
athena/ lgtm
6 years, 3 months ago (2014-09-04 15:07:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/534163002/80001
6 years, 3 months ago (2014-09-04 16:25:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/47847)
6 years, 3 months ago (2014-09-04 19:05:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/534163002/80001
6 years, 3 months ago (2014-09-05 02:36:49 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001) as 59a48f8f09105a5152effd17f85a0c3977008ebc
6 years, 3 months ago (2014-09-05 02:40:30 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:51 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f784afd4de115dba788b0adc7034a15846765ff5
Cr-Commit-Position: refs/heads/master@{#293409}

Powered by Google App Engine
This is Rietveld 408576698