Source/modules/serviceworkers/ServiceWorkerClients.cpp - Issue 534133002: [WIP] bindings: Introduce PropertyBag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 534133002: [WIP] bindings: Introduce PropertyBag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/ServiceWorkerClients.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/Source/modules/serviceworkers/ServiceWorkerClients.cpp

index 0d6474f0d6a073f3094d767cf5b7a6de59dd6279..9b3e0ebf7f395392bafae82caf18f460dae5b160 100644

--- a/Source/modules/serviceworkers/ServiceWorkerClients.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerClients.cpp

@@ -58,7 +58,7 @@ ScriptPromise ServiceWorkerClients::getAll(ScriptState* scriptState, const Dicti

ScriptPromise promise = resolver->promise();

bool includeUncontrolled = false;

- DictionaryHelper::get(options, "includeUncontrolled", includeUncontrolled);

+ options.get("includeUncontrolled", includeUncontrolled);

if (includeUncontrolled) {

// FIXME: Currently we don't support includeUncontrolled=true.

resolver->reject(DOMException::create(NotSupportedError, "includeUncontrolled parameter of getAll is not supported."));

« no previous file with comments | « Source/modules/serviceworkers/ResponseInit.h ('k') | Source/modules/webmidi/MIDIOptions.h » ('j') | no next file with comments »