Source/modules/crypto/CryptoResultImpl.cpp - Issue 534133002: [WIP] bindings: Introduce PropertyBag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/crypto/CryptoResultImpl.cpp

Issue 534133002: [WIP] bindings: Introduce PropertyBag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/crypto/CryptoResultImpl.cpp

diff --git a/Source/modules/crypto/CryptoResultImpl.cpp b/Source/modules/crypto/CryptoResultImpl.cpp

index 6ebe4ee5dc8d5b9989f6aef30624c5bedd3e4e9e..916b47b8dcebce27b2310d25e8bf5bfff2c64a28 100644

--- a/Source/modules/crypto/CryptoResultImpl.cpp

+++ b/Source/modules/crypto/CryptoResultImpl.cpp

@@ -158,7 +158,11 @@ void CryptoResultImpl::completeWithKeyPair(const WebCryptoKey& publicKey, const

ScriptState* scriptState = m_resolver->scriptState();

ScriptState::Scope scope(scriptState);

+#ifdef REMOVE_DIC

+ Dictionary keyPair(v8::Object::New(scriptState->isolate()), scriptState->isolate());

+#else

Dictionary keyPair = Dictionary::createEmpty(scriptState->isolate());

+#endif

v8::Handle<v8::Value> publicKeyValue = toV8NoInline(CryptoKey::create(publicKey), scriptState->context()->Global(), scriptState->isolate());

v8::Handle<v8::Value> privateKeyValue = toV8NoInline(CryptoKey::create(privateKey), scriptState->context()->Global(), scriptState->isolate());