Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 534133002: [WIP] bindings: Introduce PropertyBag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
diff --git a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
index a1eb2e9b2752bc1e189320392a4390f06bb994f6..fa9b234db90a2f157272dea3e5e8782a8570e9b1 100644
--- a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
+++ b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
@@ -73,7 +73,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,
v8::TryCatch tryCatch;
ScriptValue prototypeScriptValue;
- if (DictionaryHelper::get(*m_options, "prototype", prototypeScriptValue) && !prototypeScriptValue.isNull()) {
+ if (m_options->get("prototype", prototypeScriptValue) && !prototypeScriptValue.isNull()) {
ASSERT(!tryCatch.HasCaught());
if (!prototypeScriptValue.isObject()) {
CustomElementException::throwException(CustomElementException::PrototypeNotAnObject, type, exceptionState);
@@ -94,7 +94,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,
}
AtomicString extends;
- bool extendsProvidedAndNonNull = DictionaryHelper::get(*m_options, "extends", extends) && extends != "null";
+ bool extendsProvidedAndNonNull = m_options->get("extends", extends) && extends != "null";
if (tryCatch.HasCaught()) {
tryCatch.ReThrow();
« no previous file with comments | « LayoutTests/fast/events/constructors/message-event-constructor-expected.txt ('k') | Source/bindings/core/v8/Dictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698