Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 534133002: [WIP] bindings: Introduce PropertyBag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/templates/dictionary_v8.h ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY! 5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "{{v8_class}}.h" 8 #include "{{v8_class}}.h"
9 9
10 {% for filename in cpp_includes if filename != '%s.h' % v8_class %} 10 {% for filename in cpp_includes if filename != '%s.h' % v8_class %}
11 #include "{{filename}}" 11 #include "{{filename}}"
12 {% endfor %} 12 {% endfor %}
13 13
14 namespace blink { 14 namespace blink {
15 15
16 {{cpp_class}}* {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value) 16 {{cpp_class}}* {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, ExceptionState& exceptionState)
17 { 17 {
18 {{cpp_class}}* impl = {{cpp_class}}::create(); 18 {{cpp_class}}* impl = {{cpp_class}}::create();
19 // FIXME: Do not use Dictionary and DictionaryHelper 19 if (v8Value.IsEmpty() || !v8Value->IsObject())
20 // https://crbug.com/321462 20 return impl;
21 Dictionary dictionary(v8Value, isolate); 21 v8::Local<v8::Object> v8Object = v8Value->ToObject();
22 PropertyBag bag(isolate, v8Object, exceptionState);
22 {% for member in members %} 23 {% for member in members %}
23 {{member.cpp_type}} {{member.name}}; 24 {{member.cpp_type}} {{member.name}};
24 if (DictionaryHelper::get(dictionary, "{{member.name}}", {{member.name}})) 25 if (bag.get("{{member.name}}", {{member.name}}))
25 impl->{{member.setter_name}}({{member.name}}); 26 impl->{{member.setter_name}}({{member.name}});
26 {% endfor %} 27 {% endfor %}
27 return impl; 28 return impl;
28 } 29 }
29 30
30 v8::Handle<v8::Value> toV8({{cpp_class}}* impl, v8::Handle<v8::Object> creationC ontext, v8::Isolate* isolate) 31 v8::Handle<v8::Value> toV8({{cpp_class}}* impl, v8::Handle<v8::Object> creationC ontext, v8::Isolate* isolate)
31 { 32 {
32 v8::Handle<v8::Object> v8Object = v8::Object::New(isolate); 33 v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
33 {% for member in members %} 34 {% for member in members %}
34 if (impl->{{member.has_method_name}}()) 35 if (impl->{{member.has_method_name}}())
35 v8Object->Set(v8String(isolate, "{{member.name}}"), {{member.cpp_value_t o_v8_value}}); 36 v8Object->Set(v8String(isolate, "{{member.name}}"), {{member.cpp_value_t o_v8_value}});
36 {% if member.v8_default_value %} 37 {% if member.v8_default_value %}
37 else 38 else
38 v8Object->Set(v8String(isolate, "{{member.name}}"), {{member.v8_default_ value}}); 39 v8Object->Set(v8String(isolate, "{{member.name}}"), {{member.v8_default_ value}});
39 {% endif %} 40 {% endif %}
40 {% endfor %} 41 {% endfor %}
41 return v8Object; 42 return v8Object;
42 } 43 }
43 44
44 } // namespace blink 45 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/templates/dictionary_v8.h ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698