pkg/analysis_server/lib/src/services/refactoring/extract_method.dart - Issue 534123002: Integrate EXTRACT_METHOD refactoring into the server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

Issue 534123002: Integrate EXTRACT_METHOD refactoring into the server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

index 87a4bf29be00bb0c4654bae166b1c9245b74e751..d76aa53afc809677d946a18256b48902886ca703 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

@@ -460,7 +460,7 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl implements

String source = utils.getRangeText(selectionRange);

// prepare operations to replace variables with parameters

List<SourceEdit> replaceEdits = [];

- for (RefactoringMethodParameter parameter in _parametersMap.values) {

+ for (RefactoringMethodParameter parameter in _parameters) {

List<SourceRange> ranges = _parameterReferencesMap[parameter.id];

if (ranges != null) {

for (SourceRange range in ranges) {

« no previous file with comments | « pkg/analysis_server/lib/src/edit/edit_domain.dart ('k') | pkg/analysis_server/test/edit/refactoring_test.dart » ('j') | no next file with comments »