Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 534093004: Revert "[Android WebView] Terminate execution of stuck JS code on navigation requests" (Closed)

Created:
6 years, 3 months ago by mnaganov (inactive)
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "[Android WebView] Terminate execution of stuck JS code on navigation requests" This reverts commit 69538c3b061eb767d25d32edd89626282c030d86. As described in the bug, the proposed approach is invalid, as Blink's bindings code isn't ready to deal with terminated scripts properly, resulting in random crashes. Hence reverting the patch. BUG=390906 Committed: https://chromium.googlesource.com/chromium/src/+/a4afac27818dfb1d25d77a4f9a505095156032e9

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
Committed patchset #1 (id:1) manually as a4afac2.
6 years, 3 months ago (2014-09-03 16:28:05 UTC) #1
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:02 UTC) #2
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4afac27818dfb1d25d77a4f9a505095156032e9
Cr-Commit-Position: refs/heads/master@{#293146}

Powered by Google App Engine
This is Rietveld 408576698