Issue 534093003: Fix loading non-configurable non-writable value from a constant with mismatching type feedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534093003: Fix loading non-configurable non-writable value from a constant with mismatching type feedback (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix loading non-configurable non-writable value from a constant with mismatching type feedback BUG=410209 LOG=n R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23650

Patch Set 4 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -5 lines)			Patch
M	src/hydrogen.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2 3	2 chunks	+9 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-inline-constant-load.js	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jarin

lgtm with a nit https://codereview.chromium.org/534093003/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/534093003/diff/1/src/hydrogen-instructions.h#newcode3494 src/hydrogen-instructions.h:3494: virtual Handle<Map> GetMonomorphicJSObjectMap() { Should ...

6 years, 3 months ago (2014-09-03 11:51:43 UTC) #3

Toon Verwaest

6 years, 3 months ago (2014-09-03 12:13:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 23650 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 534093003: Fix loading non-configurable non-writable value from a constant with mismatching type feedback (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages