Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: media/base/video_renderer.h

Issue 534073002: Switch to using media::TimeSource inside media::RendererImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/time_source.h ('k') | media/base/wall_clock_time_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_renderer.h
diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h
index 591e5e050a1e64be2e7acda78ab6a6c9c445835f..e3d64ef9680587aab661f7a73b6a648567f73daa 100644
--- a/media/base/video_renderer.h
+++ b/media/base/video_renderer.h
@@ -19,10 +19,6 @@ class VideoDecoder;
class MEDIA_EXPORT VideoRenderer {
public:
- // Used to update the pipeline's clock time. The parameter is the time that
- // the clock should not exceed.
- typedef base::Callback<void(base::TimeDelta)> TimeCB;
-
// Used to query the current time or duration of the media.
typedef base::Callback<base::TimeDelta()> TimeDeltaCB;
@@ -37,8 +33,6 @@ class MEDIA_EXPORT VideoRenderer {
// |statistics_cb| is executed periodically with video rendering stats, such
// as dropped frames.
//
- // |time_cb| is executed whenever time has advanced by way of video rendering.
- //
// |buffering_state_cb| is executed when video rendering has either run out of
// data or has enough data to continue playback.
//
@@ -47,18 +41,14 @@ class MEDIA_EXPORT VideoRenderer {
// |error_cb| is executed if an error was encountered.
//
// |get_time_cb| is used to query the current media playback time.
- //
- // |get_duration_cb| is used to query the media duration.
virtual void Initialize(DemuxerStream* stream,
bool low_delay,
const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
- const TimeCB& time_cb,
const BufferingStateCB& buffering_state_cb,
const base::Closure& ended_cb,
const PipelineStatusCB& error_cb,
- const TimeDeltaCB& get_time_cb,
- const TimeDeltaCB& get_duration_cb) = 0;
+ const TimeDeltaCB& get_time_cb) = 0;
// Discards any video data and stops reading from |stream|, executing
// |callback| when completed.
« no previous file with comments | « media/base/time_source.h ('k') | media/base/wall_clock_time_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698