Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: content/browser/media/android/browser_media_player_manager.h

Issue 534063002: Remove OnMediaResourcesReleased callback passed to MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make ReleaseMediaResources non-virtual Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/android/browser_media_player_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/android/browser_media_player_manager.h
diff --git a/content/browser/media/android/browser_media_player_manager.h b/content/browser/media/android/browser_media_player_manager.h
index 5f3fae57565fa377082a5ecc370b690742f62377..5aae9afa9f7d82a6f9a140e1d14099d19640a5f4 100644
--- a/content/browser/media/android/browser_media_player_manager.h
+++ b/content/browser/media/android/browser_media_player_manager.h
@@ -158,9 +158,11 @@ class CONTENT_EXPORT BrowserMediaPlayerManager
// constrained by hardware and memory limits.
virtual void OnMediaResourcesRequested(int player_id);
- // Similar to the above call, MediaPlayerAndroid must call this method when
- // releasing all the decoding resources.
- virtual void OnMediaResourcesReleased(int player_id);
+ // Called when a player releases all decoding resources.
+ void ReleaseMediaResources(int player_id);
+
+ // Releases the player. However, don't remove it from |players_|.
+ void ReleasePlayer(media::MediaPlayerAndroid* player);
#if defined(VIDEO_HOLE)
void OnRequestExternalSurface(int player_id, const gfx::RectF& rect);
« no previous file with comments | « no previous file | content/browser/media/android/browser_media_player_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698