Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: gpu/config/gpu_info_collector_mac.mm

Issue 534043002: Add bits to indicate which parts of GPUInfo are collected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_info_collector_linux.cc ('k') | gpu/config/gpu_info_collector_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_info_collector_mac.mm
diff --git a/gpu/config/gpu_info_collector_mac.mm b/gpu/config/gpu_info_collector_mac.mm
index e4d404e1bf9da3842a5ffff92dce38ea57ac6017..f08ffbe0c333ceb6999c153c50414c383ba27ae3 100644
--- a/gpu/config/gpu_info_collector_mac.mm
+++ b/gpu/config/gpu_info_collector_mac.mm
@@ -62,7 +62,7 @@ GPUInfo::GPUDevice GetActiveGPU() {
}
// Scan IO registry for PCI video cards.
-bool CollectPCIVideoCardInfo(GPUInfo* gpu_info) {
+CollectInfoResult CollectPCIVideoCardInfo(GPUInfo* gpu_info) {
DCHECK(gpu_info);
GPUInfo::GPUDevice active_gpu = GetActiveGPU();
@@ -97,7 +97,7 @@ bool CollectPCIVideoCardInfo(GPUInfo* gpu_info) {
switch (gpu_list.size()) {
case 0:
- return false;
+ return kCollectInfoNonFatalFailure;
case 1:
gpu_info->gpu = gpu_list[0];
break;
@@ -154,7 +154,9 @@ bool CollectPCIVideoCardInfo(GPUInfo* gpu_info) {
}
break;
}
- return (gpu_info->gpu.vendor_id && gpu_info->gpu.device_id);
+ if (gpu_info->gpu.vendor_id == 0 || gpu_info->gpu.device_id == 0)
+ return kCollectInfoNonFatalFailure;
+ return kCollectInfoSuccess;
}
} // namespace anonymous
@@ -166,11 +168,12 @@ CollectInfoResult CollectContextGraphicsInfo(GPUInfo* gpu_info) {
gpu_info->can_lose_context =
(gfx::GetGLImplementation() == gfx::kGLImplementationEGLGLES2);
- gpu_info->finalized = true;
- return CollectGraphicsInfoGL(gpu_info);
+ CollectInfoResult result = CollectGraphicsInfoGL(gpu_info);
+ gpu_info->context_info_state = result;
+ return result;
}
-GpuIDResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
+CollectInfoResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
DCHECK(vendor_id && device_id);
GPUInfo::GPUDevice gpu = GetActiveGPU();
@@ -178,8 +181,8 @@ GpuIDResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
*device_id = gpu.device_id;
if (*vendor_id != 0 && *device_id != 0)
- return kGpuIDSuccess;
- return kGpuIDFailure;
+ return kCollectInfoSuccess;
+ return kCollectInfoNonFatalFailure;
}
CollectInfoResult CollectBasicGraphicsInfo(GPUInfo* gpu_info) {
@@ -192,8 +195,9 @@ CollectInfoResult CollectBasicGraphicsInfo(GPUInfo* gpu_info) {
gpu_info->machine_model_version =
base::IntToString(model_major) + "." + base::IntToString(model_minor);
- bool result = CollectPCIVideoCardInfo(gpu_info);
- return result ? kCollectInfoSuccess : kCollectInfoNonFatalFailure;
+ CollectInfoResult result = CollectPCIVideoCardInfo(gpu_info);
+ gpu_info->basic_info_state = result;
+ return result;
}
CollectInfoResult CollectDriverInfoGL(GPUInfo* gpu_info) {
« no previous file with comments | « gpu/config/gpu_info_collector_linux.cc ('k') | gpu/config/gpu_info_collector_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698