Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: gpu/config/gpu_info_collector_android.cc

Issue 534043002: Add bits to indicate which parts of GPUInfo are collected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_info_collector.cc ('k') | gpu/config/gpu_info_collector_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_info_collector_android.cc
diff --git a/gpu/config/gpu_info_collector_android.cc b/gpu/config/gpu_info_collector_android.cc
index fc6a54728334c1a69c13ef38dc555b77f5c4d06c..97a79e53eb6305209f782a1f97460da690e49e83 100644
--- a/gpu/config/gpu_info_collector_android.cc
+++ b/gpu/config/gpu_info_collector_android.cc
@@ -88,16 +88,15 @@ CollectInfoResult CollectContextGraphicsInfo(GPUInfo* gpu_info) {
return CollectBasicGraphicsInfo(gpu_info);
}
-GpuIDResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
+CollectInfoResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
DCHECK(vendor_id && device_id);
*vendor_id = 0;
*device_id = 0;
- return kGpuIDNotSupported;
+ return kCollectInfoNonFatalFailure;
}
CollectInfoResult CollectBasicGraphicsInfo(GPUInfo* gpu_info) {
gpu_info->can_lose_context = false;
- gpu_info->finalized = true;
gpu_info->machine_model_name =
base::android::BuildInfo::GetInstance()->model();
@@ -105,7 +104,10 @@ CollectInfoResult CollectBasicGraphicsInfo(GPUInfo* gpu_info) {
// Create a short-lived context on the UI thread to collect the GL strings.
// Make sure we restore the existing context if there is one.
ScopedRestoreNonOwnedEGLContext restore_context;
- return CollectGraphicsInfoGL(gpu_info);
+ CollectInfoResult result = CollectGraphicsInfoGL(gpu_info);
+ gpu_info->basic_info_state = result;
+ gpu_info->context_info_state = result;
+ return result;
}
CollectInfoResult CollectDriverInfoGL(GPUInfo* gpu_info) {
« no previous file with comments | « gpu/config/gpu_info_collector.cc ('k') | gpu/config/gpu_info_collector_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698