Add bits to indicate which parts of GPUInfo are collected.

content/public/browser/gpu_data_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_GPU_DATA_MANAGER_H_
 #define CONTENT_PUBLIC_BROWSER_GPU_DATA_MANAGER_H_
 
 #include <list>
 #include <string>
 
@@ skipping 42 matching lines @@
   // process, establish GPU channel, and GPU info collection, should be
   // blocked.
   // Can be called on any thread.
   // If |reason| is not NULL and GPU access is blocked, upon return, |reason|
   // contains a description of the reason why GPU access is blocked.
   virtual bool GpuAccessAllowed(std::string* reason) const = 0;
 
   // Requests complete GPUinfo if it has not already been requested
   virtual void RequestCompleteGpuInfoIfNeeded() = 0;
 
-  virtual bool IsCompleteGpuInfoAvailable() const = 0;
+  // |includes_extra| indicates whether missing DxDiagnostics on Windows
+  // is considered as incomplete; it doesn't make a difference on other
+  // platforms.
+  virtual bool IsCompleteGpuInfoAvailable(bool includes_extra) const = 0;

[Evan Stade, 2014/09/03 00:48:11]

Every time this function is called, it's called with a constant value for the
parameter, never a variable. IsCompleteGpuInfoAvailable(true) isn't very self
documenting, instead I think you should add a new function
IsCompleteGpuInfoAvailableIncludingExtra().

[Zhenyao Mo, 2014/09/03 01:31:23]

Done.

 
   // Requests that the GPU process report its current video memory usage stats,
   // which can be retrieved via the GPU data manager's on-update function.
   virtual void RequestVideoMemoryUsageStatsUpdate() const = 0;
 
   // Returns true if SwiftShader should be used.
   virtual bool ShouldUseSwiftShader() const = 0;
 
   // Register a path to SwiftShader.
   virtual void RegisterSwiftShaderPath(const base::FilePath& path) = 0;
@@ skipping 26 matching lines @@
   // Whether the browser compositor can be used.
   virtual bool CanUseGpuBrowserCompositor() const = 0;
 
  protected:
   virtual ~GpuDataManager() {}
 };
 
 };  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_GPU_DATA_MANAGER_H_