Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 534033002: Reverting since merge is breaking build. (Closed)

Created:
6 years, 3 months ago by matthewyuan
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Reverting since merge is breaking build. Revert "Fix DesktopMediaPickerViews to handle background parent_web_contents" This reverts commit 6debe587e7d6c302b98f287d1b090a50a97025e3. BUG=None Committed: https://chromium.googlesource.com/chromium/src/+/7a0797a1fd207ab17d8c218384041beec6a3015e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -38 lines) Patch
M chrome/browser/ui/views/desktop_media_picker_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 5 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/app.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/background.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/index.html View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
matthewyuan
6 years, 3 months ago (2014-09-02 23:36:41 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 7a0797a.

Powered by Google App Engine
This is Rietveld 408576698