Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 53403005: Fix leaks in AppListModelTest (Closed)

Created:
7 years, 1 month ago by stevenjb
Modified:
7 years, 1 month ago
Reviewers:
Derek Bruening, jennyz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M tools/heapcheck/suppressions.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ui/app_list/app_list_model_unittest.cc View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
7 years, 1 month ago (2013-11-05 21:53:16 UTC) #1
jennyz
lgtm
7 years, 1 month ago (2013-11-05 23:41:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/53403005/60001
7 years, 1 month ago (2013-11-05 23:52:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34643
7 years, 1 month ago (2013-11-06 00:36:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/53403005/60001
7 years, 1 month ago (2013-11-06 01:49:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220228
7 years, 1 month ago (2013-11-06 03:27:45 UTC) #6
stevenjb
7 years, 1 month ago (2013-11-06 17:42:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r233292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698