Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 53403004: Add deprecated annotation for events in API documentation. (Closed)

Created:
7 years, 1 month ago by dhnishi (use Chromium)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add deprecated annotation for events in API documentation. Example Image: http://i.imgur.com/u6f6Ewh.png NOTRY=true BUG=239196 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233032

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Yaml bump. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/api_reference.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/event.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/warning_deprecated.html View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dhnishi (use Chromium)
kalman: PTAL when you get a moment. Once this patch gets in, I'll punch out ...
7 years, 1 month ago (2013-10-31 20:13:44 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/53403004/diff/30001/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): https://codereview.chromium.org/53403004/diff/30001/chrome/common/extensions/docs/server2/api_data_source.py#newcode206 chrome/common/extensions/docs/server2/api_data_source.py:206: if (event.deprecated is not None): no need for ...
7 years, 1 month ago (2013-10-31 20:23:13 UTC) #2
dhnishi (use Chromium)
I took out the superfluous parens from the earlier deprecated patch as well. https://codereview.chromium.org/53403004/diff/30001/chrome/common/extensions/docs/server2/api_data_source.py File ...
7 years, 1 month ago (2013-10-31 21:29:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/53403004/150001
7 years, 1 month ago (2013-10-31 23:45:12 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/server2/app.yaml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-10-31 23:45:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/53403004/210001
7 years, 1 month ago (2013-11-05 18:18:50 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 18:26:23 UTC) #7
Message was sent while issue was closed.
Change committed as 233032

Powered by Google App Engine
This is Rietveld 408576698