Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 534013002: Convert chrome_unscaled_resources to use a qualified path. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert chrome_unscaled_resources to use a qualified path. BUG=401588 Committed: https://crrev.com/8414e964b6fd79733916aa2437f8ba9ab9336ab7 Cr-Commit-Position: refs/heads/master@{#293052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/app/theme/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_component_extension_resource_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
Note: This CL puts the grit header in chrome/app/theme/grit/ instead of simply chrome/grit, since tfarina ...
6 years, 3 months ago (2014-09-02 23:04:11 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-09-02 23:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/534013002/1
6 years, 3 months ago (2014-09-02 23:12:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 01ac77c0ca2f552d4ff44d5f16dad8844eccd516
6 years, 3 months ago (2014-09-03 02:22:48 UTC) #6
Lei Zhang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/533013002/ by thestig@chromium.org. ...
6 years, 3 months ago (2014-09-03 02:47:09 UTC) #7
tfarina
lgtm (rubber-stamp)
6 years, 3 months ago (2014-09-03 17:57:13 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8414e964b6fd79733916aa2437f8ba9ab9336ab7
Cr-Commit-Position: refs/heads/master@{#293052}

Powered by Google App Engine
This is Rietveld 408576698