Issue 534006: linux: set a minimum size for dialogs based on locale resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534006: linux: set a minimum size for dialogs based on locale resources (Closed)

Created:
10 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
mattm, Evan Stade

CC:
chromium-reviews_googlegroups.com, kuchhal, ben+cc_chromium.org

Visibility:
Public.

Description

linux: set a minimum size for dialogs based on locale resources GTK dialogs size to their contents, but sometimes the title is the longest string available. BUG=28024 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35855

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -7 lines)			Patch
M	chrome/app/resources/locale_settings.grd	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/import_dialog_gtk.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/create_application_shortcut_view.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/gtk_util.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View	1 chunk	+13 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mattm

lgtm http://codereview.chromium.org/534006/diff/1/7 File chrome/common/gtk_util.cc (right): http://codereview.chromium.org/534006/diff/1/7#newcode232 chrome/common/gtk_util.cc:232: gtk_window_set_resizable(window, resizable ? TRUE : FALSE); hm,is this ...

10 years, 11 months ago (2010-01-09 00:06:36 UTC) #3

Evan Martin

10 years, 11 months ago (2010-01-09 00:08:27 UTC) #4

http://codereview.chromium.org/534006/diff/1/7
File chrome/common/gtk_util.cc (right):

http://codereview.chromium.org/534006/diff/1/7#newcode232
chrome/common/gtk_util.cc:232: gtk_window_set_resizable(window, resizable ? TRUE
: FALSE);
On 2010/01/09 00:06:36, mattm wrote:
> hm,is this tenary bool->gboolean conversion really useful?    I'm pretty sure
> there's a ton of places we just pass boolean results directly to gtk
functions.

I figured it couldn't hurt; the compiler can remove it if it's redundant.

Expand Messages | Collapse Messages