Chromium Code Reviews
Help | Chromium Project | Sign in
(311)

Issue 534006: linux: set a minimum size for dialogs based on locale resources (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Evan Martin
Modified:
2 years, 11 months ago
Reviewers:
mattm, Evan Stade
CC:
chromium-reviews_googlegroups.com, kuchhal, ben+cc_chromium.org
Visibility:
Public.

Description

linux: set a minimum size for dialogs based on locale resources

GTK dialogs size to their contents, but sometimes the title is the
longest string available.

BUG=28024
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35855

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Lint Patch
M chrome/app/resources/locale_settings.grd View 1 chunk +5 lines, -0 lines 0 comments ? errors Download
M chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc View 3 chunks +5 lines, -1 line 0 comments 0 errors Download
M chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc View 3 chunks +5 lines, -1 line 0 comments 0 errors Download
M chrome/browser/gtk/import_dialog_gtk.cc View 4 chunks +5 lines, -5 lines 0 comments 0 errors Download
M chrome/browser/views/create_application_shortcut_view.cc View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/gtk_util.h View 1 chunk +7 lines, -0 lines 0 comments 0 errors Download
M chrome/common/gtk_util.cc View 1 chunk +13 lines, -0 lines 2 comments ? errors Download
Commit:

Messages

Total messages: 4
Evan Martin
4 years, 3 months ago #1
Evan Martin
4 years, 3 months ago #2
mattm
lgtm http://codereview.chromium.org/534006/diff/1/7 File chrome/common/gtk_util.cc (right): http://codereview.chromium.org/534006/diff/1/7#newcode232 chrome/common/gtk_util.cc:232: gtk_window_set_resizable(window, resizable ? TRUE : FALSE); hm,is this ...
4 years, 3 months ago #3
Evan Martin
4 years, 3 months ago #4
http://codereview.chromium.org/534006/diff/1/7
File chrome/common/gtk_util.cc (right):

http://codereview.chromium.org/534006/diff/1/7#newcode232
chrome/common/gtk_util.cc:232: gtk_window_set_resizable(window, resizable ? TRUE
: FALSE);
On 2010/01/09 00:06:36, mattm wrote:
> hm,is this tenary bool->gboolean conversion really useful?    I'm pretty sure
> there's a ton of places we just pass boolean results directly to gtk
functions.

I figured it couldn't hurt; the compiler can remove it if it's redundant.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6