Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 534005: Per discussion with mal, recognize the stable branch (parent regkey... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by John Grabowski
Modified:
2 years, 9 months ago
Reviewers:
Finnur, Mark Larson, TVL
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews
Visibility:
Public.

Description

Per discussion with mal, recognize the stable branch (parent regkey
present but no 'ap' child). Also made recognizing beta/dev a touch
more general.

BUG=31772
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35857

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Lint Patch
M chrome/common/platform_util_win.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
John Grabowski
Tested with both installed dev and stable.
4 years, 3 months ago #1
Finnur
LG, but one word of caution... http://codereview.chromium.org/534005/diff/2001/2002 File chrome/common/platform_util_win.cc (right): http://codereview.chromium.org/534005/diff/2001/2002#newcode200 chrome/common/platform_util_win.cc:200: else if (update_branch.find(L"dev") ...
4 years, 3 months ago #2
John Grabowski
http://codereview.chromium.org/534005/diff/2001/2002 File chrome/common/platform_util_win.cc (right): http://codereview.chromium.org/534005/diff/2001/2002#newcode200 chrome/common/platform_util_win.cc:200: else if (update_branch.find(L"dev") != std::wstring::npos) On 2010/01/09 00:03:01, Finnur ...
4 years, 3 months ago #3
TVL
On 2010/01/09 00:59:44, John Grabowski wrote: > http://codereview.chromium.org/534005/diff/2001/2002 > File chrome/common/platform_util_win.cc (right): > > http://codereview.chromium.org/534005/diff/2001/2002#newcode200 ...
4 years, 3 months ago #4
John Grabowski
4 years, 3 months ago #5
I tested latest dev which still uses "2.0-dev" and confirmed we print "dev"
in the about box.

jrg

On Fri, Jan 8, 2010 at 5:26 PM, <thomasvl@chromium.org> wrote:

> On 2010/01/09 00:59:44, John Grabowski wrote:
>
>> http://codereview.chromium.org/534005/diff/2001/2002
>> File chrome/common/platform_util_win.cc (right):
>>
>
>  http://codereview.chromium.org/534005/diff/2001/2002#newcode200
>> chrome/common/platform_util_win.cc:200: else if
>> (update_branch.find(L"dev") !=
>> std::wstring::npos)
>> On 2010/01/09 00:03:01, Finnur wrote:
>> > We added the minus in front so that we wouldn't parse for example Evil
>> Knievel's
>> > special "2.0-beta daredevil" code as dev.
>>
>
>  I was trying to avoid future surprises for new branch names (e.g. without
>> the
>> -), but I guess it's not possible to plan for all possible cases.  Added
>> the -
>> back in.
>>
>
> I know mac no longer uses "2.0-dev", and just uses "dev".  You might want
> to
> check with mal/laforge if they made this change on windows also since the
> numbers were out of date.
>
>
> http://codereview.chromium.org/534005
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6