Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 533973002: Add more logging to cc scheduler to debug RAF frame loss. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more logging to cc scheduler to debug RAF frame loss. BUG=393331 TEST=bots R=brianderson@chromium.org Committed: https://crrev.com/53418dcad84c86e6e93d9133380e37c976941c3d Cr-Commit-Position: refs/heads/master@{#293046}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M cc/scheduler/scheduler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Zhenyao Mo
Brian, please take a look.
6 years, 3 months ago (2014-09-02 21:42:17 UTC) #1
brianderson
https://codereview.chromium.org/533973002/diff/1/cc/scheduler/scheduler_state_machine.cc File cc/scheduler/scheduler_state_machine.cc (right): https://codereview.chromium.org/533973002/diff/1/cc/scheduler/scheduler_state_machine.cc#newcode1090 cc/scheduler/scheduler_state_machine.cc:1090: return base::StringPrintf("%c %d %d %d %d %d %d %d ...
6 years, 3 months ago (2014-09-02 22:24:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/533973002/20001
6 years, 3 months ago (2014-09-02 22:36:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-02 23:34:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5602c4251c6b6f8cfbefc6101f308dad9ea369f8
6 years, 3 months ago (2014-09-03 01:54:57 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53418dcad84c86e6e93d9133380e37c976941c3d
Cr-Commit-Position: refs/heads/master@{#293046}

Powered by Google App Engine
This is Rietveld 408576698