Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 533963002: Don't fail the style assert in Element::rendererIsFocusable if the document is active. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Don't fail the style assert in Element::rendererIsFocusable if the document is active. This avoids crashing in call sites that happen during document setup and shutdown of the document. An example of the former appears to be in the attached bug. An example of the latter is easily reproducible: load a document with hyperlinks in it, select some text via the text finding widget (ctrl-f), then click on the hyperlink. The code to close the find box will call into Blink and check if the elements are focusable. However, the elements no longer have renderers since the document has been deactivated to prepare for navigation. TBR=abarth@chromium.org BUG=251163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181497

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/dom/Element.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
chrishtr
6 years, 3 months ago (2014-09-02 21:32:19 UTC) #2
chrishtr
Updated to clear out layout state at the call site of Element::isFocusable. This is what ...
6 years, 3 months ago (2014-09-02 23:33:31 UTC) #3
chrishtr
Ping?
6 years, 3 months ago (2014-09-04 20:39:22 UTC) #4
pdr.
On 2014/09/04 20:39:22, chrishtr wrote: > Ping? LGTM
6 years, 3 months ago (2014-09-04 21:21:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/533963002/40001
6 years, 3 months ago (2014-09-04 21:22:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14435)
6 years, 3 months ago (2014-09-04 21:32:41 UTC) #9
chrishtr
Adam, need your LGTM.
6 years, 3 months ago (2014-09-04 21:34:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/533963002/40001
6 years, 3 months ago (2014-09-06 15:55:10 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-06 15:58:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181497

Powered by Google App Engine
This is Rietveld 408576698