Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 533943003: Update rules2 in app_resource_rules.plist.in to a set of rules that should work on 10.9.5 and 10.10 (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update rules2 in app_resource_rules.plist.in to a set of rules that ought to work on 10.9.5 and 10.10, with the latest Gatekeeper policy changes. This removes the “nested” tag from the live versioned directory, so that it will be treated as data instead of code. There are problems with “nested” validation of unversioned frameworks. There are other problems with “nested” allowing components to be replaced, although these can be overcome by creatively applying designated requirements to the nested components. The non-“nested” version allows us to not version the frameworks, which would introduce symbolic links and weaken v1 code signature validation as done by pre-10.9 systems because v1 code signatures do not consider symbolic links. This non-“nested” version is also the simplest change to the existing set of resource rules that works. The v2 rules2 dictionary is now identical to the v1 rules dictionary. In order for rules2 to be honored and for a v2 signature to be produced, the app must be signed on 10.9 or later. (This will also produce a v1 signature to be validated on pre-10.9 systems.) BUG=399276 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1bc56d577247e9ca6a029dd75571e79775e80343

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/installer/mac/app_resource_rules.plist.in View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-03 03:50:03 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-03 15:23:42 UTC) #3
Mark Mentovai
Committed patchset #2 (id:20001) manually as 1bc56d5 (presubmit successful).
6 years, 3 months ago (2014-09-03 16:10:03 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:55 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bc56d577247e9ca6a029dd75571e79775e80343
Cr-Commit-Position: refs/heads/master@{#293142}

Powered by Google App Engine
This is Rietveld 408576698