Source/core/accessibility/AXNodeObject.cpp - Issue 533893004: Adds accessibility role for figcaption tag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 533893004: Adds accessibility role for figcaption tag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXNodeObject.cpp

diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp

index e5010ac12a9fc8e7e9454aed3990a32448017339..6447c377132421db69c68ca492c06da2ddfbf1fb 100644

--- a/Source/core/accessibility/AXNodeObject.cpp

+++ b/Source/core/accessibility/AXNodeObject.cpp

@@ -221,6 +221,8 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()

return ParagraphRole;

if (isHTMLLabelElement(*node()))

return LabelRole;

+ if (node()->isElementNode() && node()->hasTagName(figcaptionTag))

+ return FigcaptionRole;

if (node()->isElementNode() && node()->hasTagName(figureTag))

return FigureRole;

if (node()->isElementNode() && toElement(node())->isFocusable())