chrome/browser/ui/cocoa/download/download_item_mac.mm - Issue 533883002: [Mac] Re-layout download shelf when danger state of item changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 533883002: [Mac] Re-layout download shelf when danger state of item changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix lifetime issues and add more tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/download/download_item_mac.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_mac.mm b/chrome/browser/ui/cocoa/download/download_item_mac.mm

index 3efffe17d004d0b8b376dcdb01c28f49cf316117..bf1ebc91e9e431fd4994cc5b5807438dd212131b 100644

--- a/chrome/browser/ui/cocoa/download/download_item_mac.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_mac.mm

@@ -73,10 +73,8 @@ void DownloadItemMac::OnDownloadOpened(content::DownloadItem* download) {

void DownloadItemMac::LoadIcon() {

IconManager* icon_manager = g_browser_process->icon_manager();

- if (!icon_manager) {

- NOTREACHED();

+ if (!icon_manager)

return;

- }

// We may already have this particular image cached.

base::FilePath file = download_model_.download()->GetTargetFilePath();

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »