[Mac] Re-layout download shelf when danger state of item changes.

chrome/browser/ui/cocoa/download/download_item_controller_unittest.mm

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Cocoa/Cocoa.h>
+
+#import "base/mac/scoped_nsobject.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/run_loop.h"
+#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
+#import "chrome/browser/ui/cocoa/download/download_item_controller.h"
+#import "chrome/browser/ui/cocoa/download/download_shelf_controller.h"
+#include "content/public/test/mock_download_item.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"
+#import "third_party/ocmock/OCMock/OCMock.h"
+#import "third_party/ocmock/gtest_support.h"
+
+using ::testing::Return;
+using ::testing::ReturnRefOfCopy;
+
+@interface DownloadItemController (DownloadItemControllerTest) {

[Nico, 2014/09/16 22:48:14]

do you need {} here?

[asanka, 2014/09/18 01:48:52]

Removed.

+}
+- (void)verifyProgressViewIsVisible:(bool)visible;
+- (void)verifyDangerousDownloadPromptIsVisible:(bool)visible;
+@end
+
+@implementation DownloadItemController (DownloadItemControllerTest)
+- (void)verifyProgressViewIsVisible:(bool)visible {
+  EXPECT_EQ(visible, ![progressView_ isHidden]);
+}
+
+- (void)verifyDangerousDownloadPromptIsVisible:(bool)visible {
+  EXPECT_EQ(visible, ![dangerousDownloadView_ isHidden]);
+}
+@end
+
+@interface DownloadItemControllerWithInitCallback : DownloadItemController {
+ @private
+  base::Closure initCallback_;
+}
+- (id)initWithDownload:(content::DownloadItem*)downloadItem
+                 shelf:(DownloadShelfController*)shelf
+          initCallback:(const base::Closure&)callback;
+- (void)awakeFromNib;
+@end
+
+@implementation DownloadItemControllerWithInitCallback
+
+- (id)initWithDownload:(content::DownloadItem*)downloadItem
+                 shelf:(DownloadShelfController*)shelf
+          initCallback:(const base::Closure&)callback {
+  initCallback_ = callback;
+  return [super initWithDownload:downloadItem shelf:shelf navigator:NULL];

[Nico, 2014/09/16 22:48:14]

the usual pattern is

  if ((self = [super initWithDownload:downloadItem shelf:shelf navigator:NULL]))
    initCallback_ = callback;

As is, you're accessing self (by writing to initCallback_) before calling [super
init]

[asanka, 2014/09/18 01:48:52]

Ah. Right. Fixed.

+}
+
+- (void)awakeFromNib {
+  [super awakeFromNib];
+  initCallback_.Run();
+}
+@end
+
+namespace {
+
+class DownloadItemControllerTest : public CocoaProfileTest {
+ public:
+  virtual void SetUp() OVERRIDE {
+    CocoaProfileTest::SetUp();
+    ASSERT_TRUE(browser());
+
+    id shelf_controller =
+        [OCMockObject mockForClass:[DownloadShelfController class]];
+    shelf_.reset([shelf_controller retain]);
+
+    download_item_.reset(new ::testing::NiceMock<content::MockDownloadItem>);
+    ON_CALL(*download_item_, GetState())
+        .WillByDefault(Return(content::DownloadItem::IN_PROGRESS));
+    ON_CALL(*download_item_, GetFileNameToReportUser())
+        .WillByDefault(Return(base::FilePath()));
+    ON_CALL(*download_item_, GetDangerType())
+        .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
+    ON_CALL(*download_item_, GetTargetFilePath())
+        .WillByDefault(ReturnRefOfCopy(base::FilePath()));
+    ON_CALL(*download_item_, GetLastReason())
+        .WillByDefault(Return(content::DOWNLOAD_INTERRUPT_REASON_NONE));
+    ON_CALL(*download_item_, GetURL()).WillByDefault(ReturnRefOfCopy(GURL()));
+    ON_CALL(*download_item_, GetReferrerUrl())
+        .WillByDefault(ReturnRefOfCopy(GURL()));
+    ON_CALL(*download_item_, GetTargetDisposition()).WillByDefault(
+        Return(content::DownloadItem::TARGET_DISPOSITION_OVERWRITE));
+  }
+
+  virtual void TearDown() OVERRIDE {
+    download_item_.reset();
+    [(id)shelf_ verify];
+    CocoaProfileTest::TearDown();
+  }
+
+  DownloadItemController* CreateItemController() {
+    [[(id)shelf_ expect] remove:[OCMArg any]];
+    base::RunLoop run_loop;
+    DownloadItemController* item =
+        [[[DownloadItemControllerWithInitCallback alloc]
+            initWithDownload:download_item_.get()
+                       shelf:shelf_.get()
+                initCallback:run_loop.QuitClosure()] retain];

[Nico, 2014/09/16 22:48:14]

This looks wrong: alloc returns a refcount of 1, then you retain it for a
refcount of 2, then you hand it to subview which internally also retains and
then only releases once. I think item will leak here. You probably want
s/retain/autorelease/, or use a scoped_nsobject

[asanka, 2014/09/18 01:48:52]

D'oh! Done.

+    [[test_window() contentView] addSubview:[item view]];
+    run_loop.Run();
+    return item;
+  }
+
+ protected:
+  scoped_ptr<content::MockDownloadItem> download_item_;
+  base::scoped_nsobject<DownloadShelfController> shelf_;
+};
+
+TEST_F(DownloadItemControllerTest, NormalDownload) {
+  base::scoped_nsobject<DownloadItemController> item(CreateItemController());
+
+  [item verifyProgressViewIsVisible:true];
+  [item verifyDangerousDownloadPromptIsVisible:false];
+}
+
+TEST_F(DownloadItemControllerTest, DangerousDownload) {
+  [[(id)shelf_ expect] layoutItems];
+  ON_CALL(*download_item_, GetDangerType())
+      .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE));
+  ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(true));
+  base::scoped_nsobject<DownloadItemController> item(CreateItemController());
+
+  [item verifyProgressViewIsVisible:false];
+  [item verifyDangerousDownloadPromptIsVisible:true];
+}
+
+TEST_F(DownloadItemControllerTest, NormalDownloadBecomesDangerous) {
+  base::scoped_nsobject<DownloadItemController> item(CreateItemController());
+
+  [item verifyProgressViewIsVisible:true];
+  [item verifyDangerousDownloadPromptIsVisible:false];
+
+  // The download is now marked as dangerous.
+  [[(id)shelf_ expect] layoutItems];
+  ON_CALL(*download_item_, GetDangerType())
+      .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE));
+  ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(true));
+  download_item_->NotifyObserversDownloadUpdated();
+
+  [item verifyProgressViewIsVisible:false];
+  [item verifyDangerousDownloadPromptIsVisible:true];
+
+  // And then marked as safe again.
+  [[(id)shelf_ expect] layoutItems];
+  ON_CALL(*download_item_, GetDangerType())
+      .WillByDefault(Return(content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
+  ON_CALL(*download_item_, IsDangerous()).WillByDefault(Return(false));
+  download_item_->NotifyObserversDownloadUpdated();
+
+  [item verifyProgressViewIsVisible:true];
+  [item verifyDangerousDownloadPromptIsVisible:false];
+}
+
+}  // namespace