Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 533853002: Minor fixes for the GN Windows build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M build/compiled_action.gni View 3 chunks +8 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +12 lines, -10 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-09-02 19:32:54 UTC) #2
scottmg
lgtm
6 years, 3 months ago (2014-09-02 19:34:13 UTC) #3
brettw
Committed patchset #1 (id:1) manually as e1b05dc.
6 years, 3 months ago (2014-09-02 20:03:07 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:10 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1b05dc1d206abb5cd3fc0fdd549bd88eb5452a9
Cr-Commit-Position: refs/heads/master@{#292979}

Powered by Google App Engine
This is Rietveld 408576698