Issue 533833003: [Merge] [Mac] Add tab and keyboard navigation to the new avatar bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 533833003: [Merge] [Mac] Add tab and keyboard navigation to the new avatar bubble (Closed)

Created:
6 years, 3 months ago by noms (inactive)

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge] [Mac] Add tab and keyboard navigation to the new avatar bubble Tabbing should navigate through all the visible controls. I've changed the EditablePhotoButton to actually be a button and not just an image, so that tabbing and pressing enter actually works. BUG=405056 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/489143002 Cr-Commit-Position: refs/heads/master@{#292455} (cherry picked from commit aaacc3030b8b46e4d0463d6d51f24341bf51ddfa) Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/9ed04f3

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -84 lines)			Patch
	M	chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm	View		10 chunks	+98 lines, -74 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm	View		11 chunks	+76 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

noms (inactive)

6 years, 3 months ago (2014-09-02 19:18:26 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as 9ed04f3 (presubmit
successful).

Expand Messages | Collapse Messages