flimflam: Enable -Wimplicit-function-declaration.

flimflam: Enable -Wimplicit-function-declaration.

This prevents maddening failures at runtime where we fail to load a plugin
because of an undefined symbol; having a warning for implicit function
declarations will at least cause a build break if the function doesn't appear in
a header file.

As fallout from this, there are a whole bunch of places where we /were/ using
implicit function declarations; those are all fixed by this CL.

BUG=chromium-os:9556
(yes, really)
TEST=None
Build system change only; if flimflam still builds, we're good.

Change-Id: I00c208ea5ab2dbc6c90d4761fe61fdb9dce01005
X-Where: locus chromeos-dogfood impl-fun-dec
Signed-off-by: Elly Jones <ellyjones@chromium.org>;
Signed-off-by: Jason Glasgow <jglasgow@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b42d6ee

[Elly Fong-Jones, 2010-11-29 19:07:52]

Previous issue got eaten by 'git cl patch'. Argh.

[Jason Glasgow, 2010-11-29 20:11:30]

http://codereview.chromium.org/5338008/diff/1/Makefile.am
File Makefile.am (right):

http://codereview.chromium.org/5338008/diff/1/Makefile.am#newcode93
Makefile.am:93: AM_CFLAGS = -Wimplicit-function-declaration -Werror \
Why non -Wall ?

http://codereview.chromium.org/5338008/diff/1/Makefile.plugins
File Makefile.plugins (right):

http://codereview.chromium.org/5338008/diff/1/Makefile.plugins#newcode2
Makefile.plugins:2: plugin_cflags = -Wimplicit-function-declaration -Werror
-fvisibility=hidden \
Why not -Wall ?

http://codereview.chromium.org/5338008/diff/1/include/log.h
File include/log.h (right):

http://codereview.chromium.org/5338008/diff/1/include/log.h#newcode51
include/log.h:51: unsigned __connman_debug_tags_to_mask(const char *tags, GError
**error);
__ functions are private to the src directory.
These function declarations should be in src/connman.h

http://codereview.chromium.org/5338008/diff/1/include/network.h
File include/network.h (right):

http://codereview.chromium.org/5338008/diff/1/include/network.h#newcode200
include/network.h:200: int __connman_network_activate_cellular_modem(struct
connman_network *network,
Belongs in src/connman.h

http://codereview.chromium.org/5338008/diff/1/include/service.h
File include/service.h (right):

http://codereview.chromium.org/5338008/diff/1/include/service.h#newcode174
include/service.h:174: enum connman_service_type
__connman_service_string2type(const char *str);
belongs in src/connman.h

[Elly Fong-Jones, 2010-11-29 20:40:28]

http://codereview.chromium.org/5338008/diff/1/Makefile.am
File Makefile.am (right):

http://codereview.chromium.org/5338008/diff/1/Makefile.am#newcode93
Makefile.am:93: AM_CFLAGS = -Wimplicit-function-declaration -Werror \
On 2010/11/29 20:11:30, Jason Glasgow wrote:
> Why non -Wall ?

It'd be a much bigger CL - there are a lot of warnings.

http://code.google.com/p/chromium-os/issues/detail?id=9709

http://codereview.chromium.org/5338008/diff/1/Makefile.plugins
File Makefile.plugins (right):

http://codereview.chromium.org/5338008/diff/1/Makefile.plugins#newcode2
Makefile.plugins:2: plugin_cflags = -Wimplicit-function-declaration -Werror
-fvisibility=hidden \
On 2010/11/29 20:11:30, Jason Glasgow wrote:
> Why not -Wall ?

Too many warnings to fix in this CL.

http://codereview.chromium.org/5338008/diff/1/include/log.h
File include/log.h (right):

http://codereview.chromium.org/5338008/diff/1/include/log.h#newcode51
include/log.h:51: unsigned __connman_debug_tags_to_mask(const char *tags, GError
**error);
On 2010/11/29 20:11:30, Jason Glasgow wrote:
> __ functions are private to the src directory.
> These function declarations should be in src/connman.h 

Done.

http://codereview.chromium.org/5338008/diff/1/include/network.h
File include/network.h (right):

http://codereview.chromium.org/5338008/diff/1/include/network.h#newcode200
include/network.h:200: int __connman_network_activate_cellular_modem(struct
connman_network *network,
On 2010/11/29 20:11:30, Jason Glasgow wrote:
> Belongs in src/connman.h

Done.

http://codereview.chromium.org/5338008/diff/1/include/service.h
File include/service.h (right):

http://codereview.chromium.org/5338008/diff/1/include/service.h#newcode174
include/service.h:174: enum connman_service_type
__connman_service_string2type(const char *str);
On 2010/11/29 20:11:30, Jason Glasgow wrote:
> belongs in src/connman.h

Done.

[Jason Glasgow, 2010-11-29 20:46:32]

LGTM