Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 533793002: Only target ui::ET_GESTURE_END to the default gesture handler (Closed)

Created:
6 years, 3 months ago by tdanderson
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only target ui::ET_GESTURE_END to the default gesture handler If no gesture handler has been established prior to RootView receiving a ui::ET_GESTURE_END event, do not perform any targeting based on the event's location (and therefore do not dispatch this event to any view); GESTURE_END should only ever be targeted and dispatched to the gesture handler set by a previous gesture. BUG=409918 TEST=ViewTargeterTest.ViewTargeterForGestureEvents, WidgetTest.GestureBeginAndEndEvents, WidgetTest.DisabledGestureEventTarget Committed: https://crrev.com/906a3939392344cc829470aa99819b9d559196f5 Cr-Commit-Position: refs/heads/master@{#292983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -17 lines) Patch
M ui/views/view_targeter_unittest.cc View 4 chunks +30 lines, -8 lines 0 comments Download
M ui/views/widget/root_view_targeter.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 3 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
Sadrul, PTAL.
6 years, 3 months ago (2014-09-02 18:11:39 UTC) #2
sadrul
lgtm
6 years, 3 months ago (2014-09-02 18:21:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/533793002/1
6 years, 3 months ago (2014-09-02 18:21:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2a1a37022a7b61a14ccdc396cfbdf17278bd8924
6 years, 3 months ago (2014-09-02 20:02:59 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/906a3939392344cc829470aa99819b9d559196f5
Cr-Commit-Position: refs/heads/master@{#292983}

Powered by Google App Engine
This is Rietveld 408576698