Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 533773002: Fix missing visitation of effect inputs to loads and stores. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix missing visitation of effect inputs to loads and stores. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23641

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ben Titzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/compiler/simplified-lowering.cc View 1 7 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-02 17:42:32 UTC) #1
titzer
https://codereview.chromium.org/533773002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/533773002/diff/1/src/compiler/simplified-lowering.cc#newcode191 src/compiler/simplified-lowering.cc:191: void ProcessEffect(Node* node) { Can we make this ProcessRemainingInputs(Node*, ...
6 years, 3 months ago (2014-09-03 09:03:57 UTC) #2
Michael Starzinger
Addressed comments. PTAL. https://codereview.chromium.org/533773002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/533773002/diff/1/src/compiler/simplified-lowering.cc#newcode191 src/compiler/simplified-lowering.cc:191: void ProcessEffect(Node* node) { On 2014/09/03 ...
6 years, 3 months ago (2014-09-03 10:49:59 UTC) #3
titzer
lgtm
6 years, 3 months ago (2014-09-03 11:14:26 UTC) #5
Michael Starzinger
6 years, 3 months ago (2014-09-03 11:30:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 23641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698