Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/libjingle/BUILD.gn

Issue 533743004: Fix Chrome linker errors in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libjingle/BUILD.gn
diff --git a/third_party/libjingle/BUILD.gn b/third_party/libjingle/BUILD.gn
index 553b0a5d7154e6f9055b30736994701ef92e0a5b..3ab2c0bccafaade4e0e7f0c85f3eb9e73e637d69 100644
--- a/third_party/libjingle/BUILD.gn
+++ b/third_party/libjingle/BUILD.gn
@@ -249,8 +249,7 @@ static_library("libjingle") {
"source/talk/p2p/base/constants.h",
]
deps = [
- # TODO(GYP): Uncomment when WebRTC GN build has settled.
- # "//third_party/webrtc/base:webrtc_base",
+ "//third_party/webrtc/base:webrtc_base",
":libjingle_p2p_constants",
":jingle_deps"
]
« no previous file with comments | « remoting/protocol/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698