Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: remoting/protocol/BUILD.gn

Issue 533743004: Fix Chrome linker errors in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/BUILD.gn ('k') | third_party/libjingle/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/BUILD.gn
diff --git a/remoting/protocol/BUILD.gn b/remoting/protocol/BUILD.gn
index dc75988382270d0b97537ac962170908e42e2599..189e58841c113cff22d04c8c7ef3fc99e9daa46b 100644
--- a/remoting/protocol/BUILD.gn
+++ b/remoting/protocol/BUILD.gn
@@ -136,25 +136,18 @@ static_library("protocol") {
]
configs += [ "//build/config/compiler:wexit_time_destructors" ]
- # TODO(GYP) Remove when WebRTC/jingle is converted.
- configs += [
- "//content:webrtc_stub_config",
- "//content:libjingle_stub_config",
- ]
deps = [
"//base",
"//crypto",
+ "//jingle:jingle_glue",
+ "//jingle:notifier",
"//net",
"//remoting/base",
- #'../jingle/jingle.gyp:jingle_glue', TODO(GYP)
- #'../jingle/jingle.gyp:notifier', TODO(GYP)
- #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP)
+ "//third_party/libjingle",
]
forward_dependent_configs_from = [
- #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP)
+ "//third_party/libjingle",
]
- # TODO(GYP) Remove when jingle is converted.
- direct_dependent_configs = [ "//content:libjingle_stub_config" ]
}
« no previous file with comments | « remoting/client/plugin/BUILD.gn ('k') | third_party/libjingle/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698