Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/BUILD.gn

Issue 533743004: Fix Chrome linker errors in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 679aa871fb092ecc4bbfaeb0d7a9bb8412c0d891..443c700476395681b7dad96999e231e7d4f2f8b8 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -68,6 +68,7 @@ static_library("browser") {
"//components/os_crypt",
"//components/password_manager/core/browser",
"//components/password_manager/core/common",
+ "//components/pdf/browser",
"//components/policy:policy_component",
"//components/precache/core",
"//components/query_parser",
@@ -135,9 +136,6 @@ static_library("browser") {
defines = nacl_defines
- # TODO(GYP) remove this when the real webrtc target is used below.
- configs += [ "//content:webrtc_stub_config" ]
-
deps += [
"//apps",
"//cc",
@@ -166,6 +164,7 @@ static_library("browser") {
"//mojo/public/cpp/bindings",
"//mojo/public/js/bindings",
"//mojo/system",
+ "//net:extras",
"//net:net_with_v8",
"//third_party/WebKit/public:resources",
"//third_party/expat",
@@ -175,6 +174,7 @@ static_library("browser") {
"//third_party/npapi",
"//third_party/re2",
"//third_party/smhasher:cityhash",
+ "//third_party/webrtc/modules/desktop_capture",
"//ui/gl",
"//ui/surface",
"//ui/web_dialogs",
@@ -184,8 +184,6 @@ static_library("browser") {
"//webkit/common:storage_common",
## TODO(tonyg): Remove this dependency (crbug.com/280157).
#"../testing/perf/perf_test.gyp:*", TODO(GYP)
- # Note: for this one also remove the webrtc_stub_config
- #"../third_party/webrtc/modules/modules.gyp:desktop_capture", TODO(GYP)
]
} else { # iOS
sources += rebase_path(gypi_values.chrome_browser_ios_sources,
« no previous file with comments | « no previous file | chrome/browser/extensions/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698