Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 53373002: Have NodeChildRemovalTracker constructor take a reference (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
tfarina, adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have NodeChildRemovalTracker constructor take a reference Have NodeChildRemovalTracker constructor take a reference instead of a pointer and update NodeChildRemovalTracker::node() to return a reference, as those pointers could not be null. This makes the calling code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/dom/ContainerNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeChildRemovalTracker.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
7 years, 1 month ago (2013-10-30 20:50:25 UTC) #1
adamk
lgtm
7 years, 1 month ago (2013-10-30 21:11:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/53373002/1
7 years, 1 month ago (2013-10-30 21:12:54 UTC) #3
tfarina
Shouldn't Blink adhere to Google C++ Style guide, now that it isn't tied to Apple? ...
7 years, 1 month ago (2013-10-30 21:58:50 UTC) #4
Inactive
On 2013/10/30 21:58:50, tfarina wrote: > Shouldn't Blink adhere to Google C++ Style guide, now ...
7 years, 1 month ago (2013-10-30 22:01:19 UTC) #5
commit-bot: I haz the power
List of reviewers changed. tfarina@chromium.org did a drive-by without LGTM'ing!
7 years, 1 month ago (2013-10-30 23:33:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/53373002/1
7 years, 1 month ago (2013-10-30 23:53:52 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 23:56:01 UTC) #8
Message was sent while issue was closed.
Change committed as 160988

Powered by Google App Engine
This is Rietveld 408576698