Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 533713003: Added Doc for GetAllocator in SkResourceCache and SkBitmapCache (Closed)

Created:
6 years, 3 months ago by Rémi Piotaix
Modified:
6 years, 3 months ago
Reviewers:
Justin Novosad, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Added Doc for GetAllocator in SkResourceCache and SkBitmapCache BUG=skia:2896 Committed: https://skia.googlesource.com/skia/+/8159146699f691b88f60564fc0811a6da3e8693f

Patch Set 1 #

Patch Set 2 : Oops, comment on the wrong method #

Patch Set 3 : Please kill me #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/core/SkBitmapCache.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkResourceCache.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
I like the comment additions. Was there a call-site we needed to update, that was ...
6 years, 3 months ago (2014-09-02 18:08:53 UTC) #2
reed1
The bug now is updated to make it clear that more Documentation was needed. lgtm
6 years, 3 months ago (2014-09-02 18:16:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/piotaixr@chromium.org/533713003/40001
6 years, 3 months ago (2014-09-02 18:20:29 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 8159146699f691b88f60564fc0811a6da3e8693f
6 years, 3 months ago (2014-09-02 18:27:16 UTC) #6
Justin Novosad
6 years, 3 months ago (2014-09-02 18:39:09 UTC) #7
Message was sent while issue was closed.
On 2014/09/02 18:08:53, reed1 wrote:
> I like the comment additions.
> 
> Was there a call-site we needed to update, that was crashing on NULL?

I think the only such call site is in a not yet submitted CL.

Powered by Google App Engine
This is Rietveld 408576698