Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 533703002: Remove variation_ids.h file. (Closed)

Created:
6 years, 3 months ago by gayane -on leave until 09-2017
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove variation_ids.h file. Experiments reservation mechanism moved to server-side therefore variation_ids.h is removed as it is not necessary anymore. BUG=416881 Committed: https://crrev.com/8e820179d5cdbf71e4a09516ccc225044bbe9078 Cr-Commit-Position: refs/heads/master@{#296273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -364 lines) Patch
M chrome/common/variations/uniformity_field_trials.cc View 1 chunk +15 lines, -1 line 0 comments Download
D chrome/common/variations/variation_ids.h View 1 chunk +0 lines, -363 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
gayane -on leave until 09-2017
6 years, 3 months ago (2014-09-02 15:14:50 UTC) #2
Alexei Svitkine (slow)
Please file a crbug.com to track this work - don't refer to internal bugs with ...
6 years, 2 months ago (2014-09-23 15:03:47 UTC) #3
gayane -on leave until 09-2017
6 years, 2 months ago (2014-09-23 17:44:40 UTC) #4
Alexei Svitkine (slow)
First line of CL description should be shorter. Usually, the convention I follow is to ...
6 years, 2 months ago (2014-09-23 17:50:58 UTC) #5
gayane -on leave until 09-2017
6 years, 2 months ago (2014-09-23 18:16:48 UTC) #6
Alexei Svitkine (slow)
LGTM (By the way, when replying - it's usually best practice to say something rather ...
6 years, 2 months ago (2014-09-23 18:21:29 UTC) #7
gayane -on leave until 09-2017
On 2014/09/23 18:21:29, Alexei Svitkine wrote: > LGTM > > (By the way, when replying ...
6 years, 2 months ago (2014-09-23 18:23:24 UTC) #8
Alexei Svitkine (slow)
I think it's ok to land now, should be safe. On Tue, Sep 23, 2014 ...
6 years, 2 months ago (2014-09-23 18:46:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/533703002/1
6 years, 2 months ago (2014-09-23 20:31:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 96fa63a4398bd73a2b8a286a83190b57cfacef67
6 years, 2 months ago (2014-09-23 21:58:44 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 21:59:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e820179d5cdbf71e4a09516ccc225044bbe9078
Cr-Commit-Position: refs/heads/master@{#296273}

Powered by Google App Engine
This is Rietveld 408576698