Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 533693002: Refactoring: Unify all mocks in auto roll tests. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Unify all mocks in auto roll tests. This allows to use shell command, readline and url expectations in the same list, which makes their interaction more explicit. TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -149 lines) Patch
M tools/push-to-trunk/test_scripts.py View 42 chunks +98 lines, -149 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-02 15:06:35 UTC) #2
Michael Achenbach
6 years, 3 months ago (2014-09-02 15:21:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698