Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 533673002: Expose layer hoisting API in GrContext (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Expose layer hoisting API in GrContext This CL exposes the layer hoisting API in GrContext for use in SkMultiPictureDraw::draw. It basically mirrors what SkGpuDevice::EXPERIMENTAL_drawPicture has been doing. Committed: https://skia.googlesource.com/skia/+/d61ef01f176328619d29045da3ec72e4732276b6

Patch Set 1 #

Patch Set 2 : add missing files #

Patch Set 3 : Update to ToT #

Patch Set 4 : Fix build #

Patch Set 5 : Update to ToT #

Patch Set 6 : Attach layer hoisting to MultiPictureDraw #

Patch Set 7 : Update to ToT #

Patch Set 8 : Update to ToT #

Patch Set 9 : Update to ToT #

Patch Set 10 : Get working #

Patch Set 11 : Clean up #

Patch Set 12 : Address code review issues #

Patch Set 13 : Clean up #

Patch Set 14 : Fix No GPU build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -43 lines) Patch
M src/core/SkMultiPictureDraw.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +62 lines, -3 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +22 lines, -20 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +19 lines, -14 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
robertphillips
6 years, 2 months ago (2014-10-06 19:17:44 UTC) #2
robertphillips
PTAL - I have eliminated the hoisting API from GrContext and call the GrLayerHoister API ...
6 years, 2 months ago (2014-10-07 15:51:23 UTC) #3
bsalomon
lgtm
6 years, 2 months ago (2014-10-07 16:07:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/533673002/240001
6 years, 2 months ago (2014-10-07 18:24:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1036) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/973)
6 years, 2 months ago (2014-10-07 18:28:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/533673002/260001
6 years, 2 months ago (2014-10-07 18:29:58 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-08 00:30:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/533673002/260001
6 years, 2 months ago (2014-10-08 12:03:17 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 12:17:08 UTC) #15
Message was sent while issue was closed. 
Committed patchset #14 (id:260001) as d61ef01f176328619d29045da3ec72e4732276b6

Powered by Google App Engine
This is Rietveld 408576698