Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 533553002: Changing the order of weak_ptr_factory in src/ui module (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing the order of weak_ptr_factory in src/ui module, to ensure proper cleanup while object is inactive. BUG=303818 Committed: https://crrev.com/8b5b6319ddca5d1e2044b99fddc6d3a61a6efd1c Cr-Commit-Position: refs/heads/master@{#293078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/message_center/views/message_bubble_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_bubble_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
anujsharma
6 years, 3 months ago (2014-09-02 06:44:15 UTC) #2
anujsharma
On 2014/09/02 06:44:15, anujsharma wrote: PTAL
6 years, 3 months ago (2014-09-02 06:44:49 UTC) #3
anujsharma
On 2014/09/02 09:22:49, anujsharma wrote: > mailto:anujk.sharma@samsung.com changed reviewers: > + mailto:stevenjb@chromium.org PTAL
6 years, 3 months ago (2014-09-02 09:23:06 UTC) #5
sky
LGTM
6 years, 3 months ago (2014-09-02 17:58:46 UTC) #6
anujsharma
On 2014/09/02 17:58:46, sky wrote: > LGTM @sky- Thanks a lot for LGTM.
6 years, 3 months ago (2014-09-03 02:30:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anujk.sharma@samsung.com/533553002/1
6 years, 3 months ago (2014-09-03 02:32:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as c43aa53833d01e2ff6561101c53913008f158832
6 years, 3 months ago (2014-09-03 05:48:52 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b5b6319ddca5d1e2044b99fddc6d3a61a6efd1c
Cr-Commit-Position: refs/heads/master@{#293078}

Powered by Google App Engine
This is Rietveld 408576698